Danny Tsen dtsen@us.ibm.com writes:
Please let me know when you merge the code and we can work from there.
Hi, I tried to apply and build with the v5 patch, and noticed some problems.
Declaration of _gcm_aes_encrypt / _gcm_aes_decrypt is missing. It can go in gcm-internal.h, like on this branch, https://git.lysator.liu.se/nettle/nettle/-/blob/x86_64-gcm-aes/gcm-internal.... Corresponding name mangling defines should also be in gcm-internal.h, not in the installed gcm.h header.
The file gcm-aes.c was missing in the patch. If the dummy C versions of _gcm_aes_*crypt are needed only for fat builds, maybe simplest to put the definitions in fat-ppc.c (maybe one can even use the same "return 0" dummy function for both encrypt and decrypt).
It would also be nice if you could check that the new code is used and working in a non-fat build, configured with --disable-fat --enable-power-crypto-ext.
Regards, /Niels