Hi Niels,
#defines should not start with an underscore. C standards say this is reserved (for system headers !?) and some static analyzers complain about it.
7.1.3 Reserved Identifiers ... All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use. ...
Regards, Tim
On 08/09/2018 10:16 PM, Niels Möller wrote:
I've looked into using __attribute__ ((deprecated)).
See branch attribute-deprecated. I define _NETTLE_ATTRIBUTE_DEPRECATED in nettle-types.h (and _NETTLE_ATTRIBUTE_PURE, needed in a few places). For a start, I've marked the old aes and gcm-aes interfaces as deprecated, as discussed earlier, and the obsolete _rsa_blind and _rsa_unblind functions.
Some more functions are candidates for deprecation:
Everything in des-compat.h and md5-compat.h. Unless we think it can be deleted without deprecation; I'm not aware of any usage, and they made more sense back in 2001 when Nettle-1.0 was brand new.
The "general" hmac functions: hmac_set_key, hmac_update, hmac_digest.
Regards, /Niels