I made a pull request in the repository.
regards, Mamone
On Thu, Nov 26, 2020 at 11:41 PM Niels Möller nisse@lysator.liu.se wrote:
Maamoun TK maamoun.tk@googlemail.com writes:
To suppress these warnings we need to declare a prototype for _nettle_gcm_init_key() and _nettle_gcm_hash() if
"HAVE_NATIVE_gcm_init_key"
and "HAVE_NATIVE_gcm_hash" are defined respectively.
Could be fixed in the new gcm-internal.h file. (I don't quite like that it needs any ifdefs around the declarations; the reason I had to add that was that I'd like to have the definitions be static in the case that it's all defined in C, and then it conflicts with non-static declarations in this file).
Also, I think an error will pop up in x86_64 build if gcm_hash8 is
enabled,
we can fix this error by replacing the line 156 "#define gcm_hash _nettle_gcm_hash8" with "#define _nettle_gcm_hash _nettle_gcm_hash8"
You're right, it's broken on x86_64.
Let me know if you want me to make a pull request for these changes.
If you can help out with that, that's much appreciated.
Regards, /Niels
-- Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. Internet email is subject to wholesale government surveillance.