Nikos Mavrogiannopoulos nmav@gnutls.org writes:
The attached patch renames the salsa20r12_crypt function to estream_salsa20_crypt(),
Why? Is "estream" clearer than "r12"? Do you expect more functions with the estream prefix? I'm not sure I like it as a prefix (I mean, we don't call it "nist_aes", just "aes").
If we think "estream variant of salsa20" is somehow clearer than "12-round variant of salsa", then I think "estream" should be a suffix rather than a prefix.
What is missing is an equivalent of x86_64/salsa20-crypt.asm for the estream variant.
One could add a round argument (and rename it _salsa20_crypt, with wrappers for useful variants).
Regards, /Niels