Re: [PATCH v2 3/6] gosthash94: switch to using MD_UPDATE() macro

Dmitry Eremin-Solenikov dbaryshkov@gmail.com writes:

--- a/gosthash94.h +++ b/gosthash94.h @@ -87,8 +87,9 @@ struct gosthash94_ctx { uint32_t hash[8]; /* algorithm 256-bit state */ uint32_t sum[8]; /* sum of processed message blocks */

• uint64_t length; /* number of processed bytes */
• uint8_t message[GOSTHASH94_BLOCK_SIZE]; /* 256-bit buffer for leftovers */

• uint64_t count; /* Block count */
• unsigned index; /* Into buffer */
• uint8_t block[GOSTHASH94_BLOCK_SIZE]; /* 256-bit buffer for leftovers */

}; #define gosthash94cp_ctx gosthash94_ctx

This is a nice cleanup, but it's also both an ABI break, right? Since the size of this struct is changed.

Unfortunate I missed this one when I moved around fields in other hash contexts prior to the 3.5 release (which was an abi break), probably because I was guided by the findings of "git grep block".

Regards, /Niels