Nikos Mavrogiannopoulos nmav@redhat.com writes:
The latter was to avoid abidiff differences to hogweed's ABI when built with different gmp versions. For that I renamed the gmp-glue _nettle_* symbols to _inettle_*.
Can you explain what the problem is? I know there's been some hassle also for the debian maintainer, but apparently solvable by other means.
I don't like the "_inettle_" prefix, though. We shouldn't add even more prefixes to the symbol namespace (for an ELF shared library, it might not matter much, if the point is to make the symbols in question unexported, but we also have static libraries).
Would it work to instead exclude _nettle_mp?_* or so?
--- a/testsuite/Makefile.in +++ b/testsuite/Makefile.in @@ -84,7 +84,7 @@ all: $(EXTRA_TARGETS) # explicit rule for each and every executable.
LIB_HOGWEED = @IF_HOGWEED@ -lhogweed -TEST_OBJS = testutils.$(OBJEXT) ../nettle-internal.$(OBJEXT) \ +TEST_OBJS = testutils.$(OBJEXT) ../gmp-glue.$(OBJEXT) ../nettle-internal.$(OBJEXT) \ $(LIB_HOGWEED) -lnettle $(LIBS)
Why is this? Test code using the gmp-glue functions, and they're now hidden in the library?
From f13aae72cba67bb8bc7462b88d79a7e29ca2d6bb Mon Sep 17 00:00:00 2001 From: Nikos Mavrogiannopoulos nmav@redhat.com Date: Thu, 10 Mar 2016 17:44:08 +0100 Subject: [PATCH 2/3] configure: export mp_ symbols when compiling with mini-gmp
This addresses build issue when compiling with --enable-mini-gmp and the symbol script being used.
Applied.
From 97731353e81dba097c533a1b5be285508efc3384 Mon Sep 17 00:00:00 2001 From: Nikos Mavrogiannopoulos nmav@redhat.com Date: Thu, 10 Mar 2016 17:45:07 +0100 Subject: [PATCH 3/3] .gitlab-ci.yml: enhance with mini-gmp builds
Applied.
Regards, /Niels