- Pike-automation - lists.lysator.liu.se

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 17 Dec '16

17 Dec '16

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1397298: Error handling issues (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/sscanf.c: 341 in pcharp_to_svalue_rec() ________________________________________________________________________________________________________ *** CID 1397298: Error handling issues (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/sscanf.c: 341 in pcharp_to_svalue_rec() 335 skip_to_token(str,len); 336 if(EXTRACT_PCHARP(*str)=='>' ) 337 { 338 CONSUME(1); 339 FINISH(f_aggregate_multiset); 340 } >>> CID 1397298: Error handling issues (CHECKED_RETURN) >>> Calling "pcharp_to_svalue_rec" without checking return value (as is done elsewhere 4 out of 5 times). 341 pcharp_to_svalue_rec(str,len); 342 skip_to_token(str,len); 343 tmp=READ(); 344 if(tmp == '>' ) 345 FINISH(f_aggregate_multiset); 346 if( tmp != ',' ) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 10 Dec '16

10 Dec '16

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1396994: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/Pike-v8.1-snapshot/src/builtin_functions.c: 3276 in f_crypt() ________________________________________________________________________________________________________ *** CID 1396994: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/Pike-v8.1-snapshot/src/builtin_functions.c: 3276 in f_crypt() 3270 if (args > 1) { 3271 pop_n_elems(args-1); 3272 args = 1; 3273 } 3274 } 3275 #ifdef HAVE_CRYPT >>> CID 1396994: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pwd" to "crypt", which dereferences it. 3276 ret = (char *)crypt(pwd, saltp); 3277 #else 3278 #ifdef HAVE__CRYPT 3279 ret = (char *)_crypt(pwd, saltp); 3280 #else 3281 #error No crypt function found and fallback failed. ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 05 Nov '16

05 Nov '16

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 2 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1376003: Error handling issues (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/object.c: 2359 in gc_mark_object_as_referenced() ________________________________________________________________________________________________________ *** CID 1376003: Error handling issues (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/object.c: 2359 in gc_mark_object_as_referenced() 2353 struct svalue *s; 2354 s=(struct svalue *)(pike_frame->current_storage + id->func.offset); 2355 dmalloc_touch_svalue(s); 2356 if ((TYPEOF(*s) != T_OBJECT && TYPEOF(*s) != T_FUNCTION) || 2357 s->u.object != o || !(id_flags & IDENTIFIER_NO_THIS_REF)) { 2358 if (id_flags & IDENTIFIER_WEAK) { >>> CID 1376003: Error handling issues (CHECKED_RETURN) >>> Calling "gc_mark_weak_svalues" without checking return value (as is done elsewhere 5 out of 6 times). 2359 gc_mark_weak_svalues(s, 1); 2360 } else { 2361 gc_mark_svalues(s, 1); 2362 } 2363 } 2364 }else{ ** CID 1376002: Error handling issues (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/object.c: 2435 in real_gc_cycle_check_object() ________________________________________________________________________________________________________ *** CID 1376002: Error handling issues (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/object.c: 2435 in real_gc_cycle_check_object() 2429 struct svalue *s; 2430 s=(struct svalue *)(pike_frame->current_storage + id->func.offset); 2431 dmalloc_touch_svalue(s); 2432 if ((TYPEOF(*s) != T_OBJECT && TYPEOF(*s) != T_FUNCTION) || 2433 s->u.object != o || !(id_flags & IDENTIFIER_NO_THIS_REF)) { 2434 if (id_flags & IDENTIFIER_WEAK) { >>> CID 1376002: Error handling issues (CHECKED_RETURN) >>> Calling "gc_cycle_check_weak_svalues" without checking return value (as is done elsewhere 5 out of 6 times). 2435 gc_cycle_check_weak_svalues(s, 1); 2436 } else { 2437 gc_cycle_check_svalues(s, 1); 2438 } 2439 } 2440 }else{ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 04 Nov '16

04 Nov '16

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1375989: (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 3872 in low_pike_types_le() /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 3895 in low_pike_types_le() /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 4090 in low_pike_types_le() ________________________________________________________________________________________________________ *** CID 1375989: (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 3872 in low_pike_types_le() 3866 goto recurse; 3867 } 3868 if ((a->flags | b->flags) & PT_FLAG_ASSIGN) { 3869 /* Note that we need to recurse, since there are T_ASSIGN nodes 3870 * in the cdr that need to be executed. 3871 */ >>> CID 1375989: (CHECKED_RETURN) >>> Calling "low_pike_types_le" without checking return value (as is done elsewhere 28 out of 35 times). 3872 low_pike_types_le(a->cdr, b, array_cnt, flags); 3873 } 3874 return 1; 3875 3876 case T_OR: 3877 /* OK, if both of the parts are a subset, /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 3895 in low_pike_types_le() 3889 } else { 3890 ret = low_pike_types_le(a->car, b, array_cnt, flags); 3891 #ifdef TYPE_GROUPING 3892 if (!ret == !(flags & LE_A_GROUPED)) { 3893 if ((a->flags | b->flags) & PT_FLAG_ASSIGN) { 3894 /* Note: Needed for side effects... */ >>> CID 1375989: (CHECKED_RETURN) >>> Calling "low_pike_types_le" without checking return value (as is done elsewhere 28 out of 35 times). 3895 low_pike_types_le(a->cdr, b, array_cnt, flags); 3896 } 3897 return ret; 3898 } 3899 #else 3900 if (!ret) return 0; /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 4090 in low_pike_types_le() 4084 */ 4085 ret = low_pike_types_le(a, b->car, array_cnt, flags); 4086 #ifdef TYPE_GROUPING 4087 if (!ret != !(flags & LE_B_GROUPED)) { 4088 if ((a->flags | b->flags) & PT_FLAG_ASSIGN) { 4089 /* Note: Needed for side effects... */ >>> CID 1375989: (CHECKED_RETURN) >>> Calling "low_pike_types_le" without checking return value (as is done elsewhere 28 out of 35 times). 4090 low_pike_types_le(a, b->cdr, array_cnt, flags); 4091 } 4092 return ret; 4093 } 4094 #else 4095 if (ret) return ret; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 19 May '16

19 May '16

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1362005: Uninitialized variables (UNINIT) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Gmp/mpf.cmod: 979 in f_mpf_pow() ________________________________________________________________________________________________________ *** CID 1362005: Uninitialized variables (UNINIT) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Gmp/mpf.cmod: 979 in f_mpf_pow() 973 */ 974 break; 975 } 976 res = get_mpf_with_prec( mpf_get_prec(THISMPF) ); 977 a = OBTOMPF(res); 978 >>> CID 1362005: Uninitialized variables (UNINIT) >>> Using uninitialized value "ai". 979 if( ai < 0 ) 980 { 981 mpf_pow_ui( a, THISMPF, -ai ); 982 mpf_ui_div( a, 1, a ); 983 } 984 else ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/pike-master?tab=overview To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://scan.coverity.com/subscriptions/edit?email=pike-automation%40lists.…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 18 May '16

18 May '16

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1361928: Integer handling issues (NEGATIVE_RETURNS) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 294 in f_sqrt() ________________________________________________________________________________________________________ *** CID 1361928: Integer handling issues (NEGATIVE_RETURNS) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 294 in f_sqrt() 288 return; 289 } 290 sp[-1].u.float_number = FL(sqrt,sp[-1].u.float_number); 291 } 292 else if(TYPEOF(sp[-1]) == T_OBJECT) 293 { >>> CID 1361928: Integer handling issues (NEGATIVE_RETURNS) >>> Assigning: signed variable "i" = "FIND_LFUN". 294 int i = FIND_LFUN(sp[-1].u.object->prog,LFUN__SQRT); 295 apply_low(sp[-1].u.object,i,0); 296 stack_swap(); 297 pop_stack(); 298 } 299 else ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/pike-master?tab=overview To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://scan.coverity.com/subscriptions/edit?email=pike-automation%40lists.…

1 0

New Defects reported by Coverity Scan for Pike-experiment
by scan-admin＠coverity.com 18 Apr '16

18 Apr '16

Hi, Please find the latest report on new defect(s) introduced to Pike-experiment found with Coverity Scan. 1 new defect(s) introduced to Pike-experiment found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1358635: Control flow issues (MISSING_BREAK) /home/covscan/pike/pike-git/src/interpret.c: 3634 in frame_execute() ________________________________________________________________________________________________________ *** CID 1358635: Control flow issues (MISSING_BREAK) /home/covscan/pike/pike-git/src/interpret.c: 3634 in frame_execute() 3628 TYPE_T t = PTR_TO_INT(frame->pc); 3629 o_cast(type, t); 3630 break; 3631 } 3632 case FRAME_BUILTIN: 3633 Pike_fatal("Cannot execute builtin frame.\n"); >>> CID 1358635: Control flow issues (MISSING_BREAK) >>> The above case falls through to this one. 3634 default: 3635 #ifdef PIKE_DEBUG 3636 Pike_fatal("trying to execute uninitialized frame.\n"); 3637 #else 3638 UNREACHABLE(return); 3639 #endif ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/pike-experiment?tab=overview To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://scan.coverity.com/subscriptions/edit?email=pike-automation%40lists.…

1 0

New Defects reported by Coverity Scan for Pike-experiment
by scan-admin＠coverity.com 17 Apr '16

17 Apr '16

Hi, Please find the latest report on new defect(s) introduced to Pike-experiment found with Coverity Scan. 6 new defect(s) introduced to Pike-experiment found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) ** CID 1358595: Incorrect expression (UNUSED_VALUE) /home/covscan/pike/pike-git/src/interpret.c: 2202 in unlink_previous_frame() ________________________________________________________________________________________________________ *** CID 1358595: Incorrect expression (UNUSED_VALUE) /home/covscan/pike/pike-git/src/interpret.c: 2202 in unlink_previous_frame() 2196 */ 2197 current->save_sp=prev->save_sp; 2198 current->save_mark_sp=prev->save_mark_sp; 2199 current->flags = prev->flags; 2200 2201 /* Unlink the top frame temporarily. */ >>> CID 1358595: Incorrect expression (UNUSED_VALUE) >>> Assigning value from "prev" to "Pike_interpreter_pointer->frame_pointer" here, but that stored value is overwritten before it can be used. 2202 Pike_interpreter.frame_pointer=prev; 2203 2204 #ifdef PROFILING 2205 { 2206 /* We must update the profiling info of the previous frame 2207 * to account for that the current frame has gone away. ** CID 1358594: Control flow issues (MISSING_BREAK) /home/covscan/pike/pike-git/src/interpret.c: 1956 in do_trace_frame_call() ________________________________________________________________________________________________________ *** CID 1358594: Control flow issues (MISSING_BREAK) /home/covscan/pike/pike-git/src/interpret.c: 1956 in do_trace_frame_call() 1950 safe_describe_svalue(&obj_sval, 0, NULL); 1951 obj_name = complex_free_buf(&save_buf); 1952 PIKE_FN_START(function->name->size_shift == 0 ? 1953 function->name->str : "[widestring fn name]", 1954 obj_name.str); 1955 } >>> CID 1358594: Control flow issues (MISSING_BREAK) >>> The above case falls through to this one. 1956 case FRAME_CLONE: 1957 case FRAME_PARENT_CLONE: 1958 if (UNLIKELY(Pike_interpreter.trace_level)) { 1959 struct svalue tmp; 1960 struct program *p = frame->ptr; 1961 dynamic_buffer save_buf; ** CID 1358593: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/pike-git/src/modules/Image/match.h: 202 in image_match_phase() ________________________________________________________________________________________________________ *** CID 1358593: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/pike-git/src/modules/Image/match.h: 202 in image_match_phase() 196 DOUBLE_LOOP(0,1,1, *1, *1, *1) 197 else if (type==2) 198 DOUBLE_LOOP(0, haystack_certi[j], needle_certi[ny*nxs+nx],.r,.g,.b) 199 else if (type==3) 200 DOUBLE_LOOP(AVOID_IS_TOO_BIG,1,1, *1, *1, *1) 201 else if (type==4) >>> CID 1358593: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "haystack_certi". 202 DOUBLE_LOOP(AVOID_IS_TOO_BIG, haystack_certi[j], needle_certi[ny*nxs+nx],.r,.g,.b) 203 204 #undef NORMCODE 205 #undef AVOID_IS_TOO_BIG 206 #undef PIXEL_VALUE_DISTANCE 207 #undef DOUBLE_LOOP ** CID 1358592: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/pike-git/src/modules/Image/match.h: 202 in image_match_norm_corr() ________________________________________________________________________________________________________ *** CID 1358592: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/pike-git/src/modules/Image/match.h: 202 in image_match_norm_corr() 196 DOUBLE_LOOP(0,1,1, *1, *1, *1) 197 else if (type==2) 198 DOUBLE_LOOP(0, haystack_certi[j], needle_certi[ny*nxs+nx],.r,.g,.b) 199 else if (type==3) 200 DOUBLE_LOOP(AVOID_IS_TOO_BIG,1,1, *1, *1, *1) 201 else if (type==4) >>> CID 1358592: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "haystack_certi". 202 DOUBLE_LOOP(AVOID_IS_TOO_BIG, haystack_certi[j], needle_certi[ny*nxs+nx],.r,.g,.b) 203 204 #undef NORMCODE 205 #undef AVOID_IS_TOO_BIG 206 #undef PIXEL_VALUE_DISTANCE 207 #undef DOUBLE_LOOP ** CID 1358591: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/pike-git/src/modules/Image/match.h: 202 in image_match_norm() ________________________________________________________________________________________________________ *** CID 1358591: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/pike-git/src/modules/Image/match.h: 202 in image_match_norm() 196 DOUBLE_LOOP(0,1,1, *1, *1, *1) 197 else if (type==2) 198 DOUBLE_LOOP(0, haystack_certi[j], needle_certi[ny*nxs+nx],.r,.g,.b) 199 else if (type==3) 200 DOUBLE_LOOP(AVOID_IS_TOO_BIG,1,1, *1, *1, *1) 201 else if (type==4) >>> CID 1358591: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "haystack_certi". 202 DOUBLE_LOOP(AVOID_IS_TOO_BIG, haystack_certi[j], needle_certi[ny*nxs+nx],.r,.g,.b) 203 204 #undef NORMCODE 205 #undef AVOID_IS_TOO_BIG 206 #undef PIXEL_VALUE_DISTANCE 207 #undef DOUBLE_LOOP ** CID 1358590: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/pike-git/src/modules/Image/match.h: 202 in image_match() ________________________________________________________________________________________________________ *** CID 1358590: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/pike-git/src/modules/Image/match.h: 202 in image_match() 196 DOUBLE_LOOP(0,1,1, *1, *1, *1) 197 else if (type==2) 198 DOUBLE_LOOP(0, haystack_certi[j], needle_certi[ny*nxs+nx],.r,.g,.b) 199 else if (type==3) 200 DOUBLE_LOOP(AVOID_IS_TOO_BIG,1,1, *1, *1, *1) 201 else if (type==4) >>> CID 1358590: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "haystack_certi". 202 DOUBLE_LOOP(AVOID_IS_TOO_BIG, haystack_certi[j], needle_certi[ny*nxs+nx],.r,.g,.b) 203 204 #undef NORMCODE 205 #undef AVOID_IS_TOO_BIG 206 #undef PIXEL_VALUE_DISTANCE 207 #undef DOUBLE_LOOP ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/pike-experiment?tab=overview To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://scan.coverity.com/subscriptions/edit?email=pike-automation%40lists.…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 09 Apr '16

09 Apr '16

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 5 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1358398: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_8bit_cube() ________________________________________________________________________________________________________ *** CID 1358398: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_8bit_cube() 429 { 430 lc->dest.r=((int)(((val.r*red+hred)>>8)*redf)); 431 lc->dest.g=((int)(((val.g*green+hgreen)>>8)*greenf)); 432 lc->dest.b=((int)(((val.b*blue+hblue)>>8)*bluef)); 433 434 lc->index=i= >>> CID 1358398: Code maintainability issues (UNUSED_VALUE) >>> Assigning value from "(val.r * red + hred >> 8) + ((val.g * green + hgreen >> 8) + (val.b * blue + hblue >> 8) * green) * red" to "i" here, but that stored value is overwritten before it can be used. 435 ((val.r*red+hred)>>8)+ 436 (((val.g*green+hgreen)>>8)+ 437 ((val.b*blue+hblue)>>8)*green)*red; 438 439 NCTLU_CACHE_HIT_WRITE; 440 ** CID 1358397: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_32bit_cube() ________________________________________________________________________________________________________ *** CID 1358397: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_32bit_cube() 429 { 430 lc->dest.r=((int)(((val.r*red+hred)>>8)*redf)); 431 lc->dest.g=((int)(((val.g*green+hgreen)>>8)*greenf)); 432 lc->dest.b=((int)(((val.b*blue+hblue)>>8)*bluef)); 433 434 lc->index=i= >>> CID 1358397: Code maintainability issues (UNUSED_VALUE) >>> Assigning value from "(val.r * red + hred >> 8) + ((val.g * green + hgreen >> 8) + (val.b * blue + hblue >> 8) * green) * red" to "i" here, but that stored value is overwritten before it can be used. 435 ((val.r*red+hred)>>8)+ 436 (((val.g*green+hgreen)>>8)+ 437 ((val.b*blue+hblue)>>8)*green)*red; 438 439 NCTLU_CACHE_HIT_WRITE; 440 ** CID 1358396: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_16bit_cube() ________________________________________________________________________________________________________ *** CID 1358396: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_16bit_cube() 429 { 430 lc->dest.r=((int)(((val.r*red+hred)>>8)*redf)); 431 lc->dest.g=((int)(((val.g*green+hgreen)>>8)*greenf)); 432 lc->dest.b=((int)(((val.b*blue+hblue)>>8)*bluef)); 433 434 lc->index=i= >>> CID 1358396: Code maintainability issues (UNUSED_VALUE) >>> Assigning value from "(val.r * red + hred >> 8) + ((val.g * green + hgreen >> 8) + (val.b * blue + hblue >> 8) * green) * red" to "i" here, but that stored value is overwritten before it can be used. 435 ((val.r*red+hred)>>8)+ 436 (((val.g*green+hgreen)>>8)+ 437 ((val.b*blue+hblue)>>8)*green)*red; 438 439 NCTLU_CACHE_HIT_WRITE; 440 ** CID 1358395: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_map_to_cube() ________________________________________________________________________________________________________ *** CID 1358395: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_map_to_cube() 429 { 430 lc->dest.r=((int)(((val.r*red+hred)>>8)*redf)); 431 lc->dest.g=((int)(((val.g*green+hgreen)>>8)*greenf)); 432 lc->dest.b=((int)(((val.b*blue+hblue)>>8)*bluef)); 433 434 lc->index=i= >>> CID 1358395: Code maintainability issues (UNUSED_VALUE) >>> Assigning value from "(val.r * red + hred >> 8) + ((val.g * green + hgreen >> 8) + (val.b * blue + hblue >> 8) * green) * red" to "i" here, but that stored value is overwritten before it can be used. 435 ((val.r*red+hred)>>8)+ 436 (((val.g*green+hgreen)>>8)+ 437 ((val.b*blue+hblue)>>8)*green)*red; 438 439 NCTLU_CACHE_HIT_WRITE; 440 ** CID 1358394: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/system/system.c: 1894 in get_inet_addr() ________________________________________________________________________________________________________ *** CID 1358394: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/system/system.c: 1894 in get_inet_addr() 1888 * cf [bug 7599] and https://bugs.python.org/issue17269 . 1889 */ 1890 hints.ai_flags |= AI_NUMERICSERV; 1891 sprintf(service = servnum_buf, "%"PRINTPIKEINT"d", port & 0xffff); 1892 } 1893 >>> CID 1358394: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> The expression "(err = getaddrinfo(name, service, &hints, &res)) && 4" is suspicious because it performs a Boolean operation on a constant other than 0 or 1. 1894 if( (err=getaddrinfo(name, service, &hints, &res)) && AI_NUMERICHOST ) 1895 { 1896 /* Try again without AI_NUMERICHOST. */ 1897 hints.ai_flags &= ~AI_NUMERICHOST; 1898 err=getaddrinfo(name, service, &hints, &res); 1899 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/pike-master?tab=overview To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://scan.coverity.com/subscriptions/edit?email=pike-automation%40lists.…

1 0

New Defects reported by Coverity Scan for Pike-experiment
by scan-admin＠coverity.com 06 Apr '16

06 Apr '16

Hi, Please find the latest report on new defect(s) introduced to Pike-experiment found with Coverity Scan. 1 new defect(s) introduced to Pike-experiment found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1358354: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/pike-git/src/builtin.cmod: 4280 in low_automap() ________________________________________________________________________________________________________ *** CID 1358354: Null pointer dereferences (FORWARD_NULL) /home/covscan/pike/pike-git/src/builtin.cmod: 4280 in low_automap() 4274 push_svalue(ITEM(tmpargs[e].u.array)+x); 4275 }else{ 4276 push_svalue(tmpargs+e); 4277 } 4278 } 4279 >>> CID 1358354: Null pointer dereferences (FORWARD_NULL) >>> Comparing "reuse_ctx" to null implies that "reuse_ctx" might be null. 4280 if(reuse_ctx != NULL) 4281 apply_svalue_reuse_context (reuse_ctx); 4282 else 4283 low_automap(d+1,depth,fun,real_args,args); 4284 stack_pop_to_no_free (ITEM(ret) + x); 4285 types |= 1 << TYPEOF(ITEM(ret)[x]); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/pike-experiment?tab=overview To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://scan.coverity.com/subscriptions/edit?email=pike-automation%40lists.…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

Pike-automation