Pike-automation

pike-automation@lists.lysator.liu.se

62 discussions

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 25 Dec '17

25 Dec '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1426948: Uninitialized variables (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 593 in f_TM_create_3() ________________________________________________________________________________________________________ *** CID 1426948: Uninitialized variables (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 593 in f_TM_create_3() 587 PIKEFUN void create( int year, int(0..11) mon, int(1..31) mday, 588 int(0..24) hour, int(0..59) min, int(0..59) sec, 589 string|void timezone ) 590 { 591 struct tm *t = &THIS->t; 592 int use_utc; >>> CID 1426948: Uninitialized variables (UNINIT) >>> Using uninitialized value "use_utc". 593 t->tm_isdst = use_utc ? 0 : -1; 594 t->tm_year = year - 1900; 595 t->tm_mon = mon; 596 t->tm_mday = mday; 597 t->tm_hour = hour; 598 t->tm_min = min; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 26 Nov '17

26 Nov '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1423308: Control flow issues (DEADCODE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/las.c: 1632 in resolv_type() ________________________________________________________________________________________________________ *** CID 1423308: Control flow issues (DEADCODE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/las.c: 1632 in resolv_type() 1626 } 1627 } 1628 1629 switch(TYPEOF(Pike_sp[-1])) { 1630 case T_FUNCTION: 1631 if((p = program_from_function(Pike_sp-1))) { >>> CID 1423308: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "0" inside this statement: "debug_push_object_type(0, (...". 1632 push_object_type(0, p?(p->id):0); 1633 break; 1634 } else { 1635 /* Attempt to get the return type for the function. */ 1636 struct pike_type *a, *b; 1637 a = get_type_of_svalue(Pike_sp-1); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 08 Oct '17

08 Oct '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1419034: Uninitialized variables (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/code/amd64.c: 2809 in ins_f_byte() ________________________________________________________________________________________________________ *** CID 1419034: Uninitialized variables (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/code/amd64.c: 2809 in ins_f_byte() 2803 #endif /* MACHINE_CODE_STACK_FRAMES */ 2804 } 2805 2806 amd64_call_c_opcode(addr,flags); 2807 2808 if (instrs[b].flags & I_RETURN) { >>> CID 1419034: Uninitialized variables (UNINIT) >>> Declaring variable "label_C" without initializer. 2809 LABELS(); 2810 2811 if ((b + F_OFFSET) == F_RETURN_IF_TRUE) { 2812 /* Kludge. We must check if the ret addr is 2813 * PC + JUMP_EPILOGUE_SIZE. */ 2814 mov_rip_imm_reg(JUMP_EPILOGUE_SIZE, P_REG_RCX); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 07 Oct '17

07 Oct '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 3 new defect(s) introduced to Pike-master found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1418981: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/multiset.c: 2876 in multiset_equal_p() ________________________________________________________________________________________________________ *** CID 1418981: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/multiset.c: 2876 in multiset_equal_p() 2870 if (p->pointer_a == (void *) a && p->pointer_b == (void *) b) 2871 return 1; 2872 2873 add_ref (rd.a_msd); 2874 add_ref (rd.b_msd); 2875 SET_ONERROR (uwp, free_recovery_data, &rd); >>> CID 1418981: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "rd.a_msd->root". 2876 a_node = low_multiset_first (rd.a_msd); 2877 b_node = low_multiset_first (rd.b_msd); 2878 res = 1; 2879 2880 #define WITH_NODES_BLOCK(TYPE, IND) \ 2881 do { \ ** CID 742549: (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/stralloc.c: 2038 in string_replace() /home/covbuilder/pike/Pike-v8.1-snapshot/src/stralloc.c: 2056 in string_replace() ________________________________________________________________________________________________________ *** CID 742549: (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/stralloc.c: 2038 in string_replace() 2032 { 2033 case 0: f=(replace_searchfunc)mojt.vtab->func0; break; 2034 case 1: f=(replace_searchfunc)mojt.vtab->func1; break; 2035 case 2: f=(replace_searchfunc)mojt.vtab->func2; break; 2036 } 2037 >>> CID 742549: (FORWARD_NULL) >>> Dereferencing null pointer "f". 2038 while((s = f(mojt.data, s, (end-s)>>str->size_shift))) 2039 { 2040 delimeters++; 2041 s+=del->len << str->size_shift; 2042 } 2043 /home/covbuilder/pike/Pike-v8.1-snapshot/src/stralloc.c: 2056 in string_replace() 2050 2051 ret=begin_wide_shared_string(str->len + (to->len-del->len)*delimeters, shift); 2052 } 2053 s=str->str; 2054 r=MKPCHARP_STR(ret); 2055 >>> CID 742549: (FORWARD_NULL) >>> Dereferencing null pointer "f". 2056 while((tmp = f(mojt.data, s, (end-s)>>str->size_shift))) 2057 { 2058 #ifdef PIKE_DEBUG 2059 if(tmp + (del->len << str->size_shift) > end) 2060 Pike_fatal("SearchMojt found a match beyond end of string!!!\n"); 2061 #endif ** CID 742518: (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 3859 in f_single_string_replace_cq__backtick_28_29() /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 3877 in f_single_string_replace_cq__backtick_28_29() ________________________________________________________________________________________________________ *** CID 742518: (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 3859 in f_single_string_replace_cq__backtick_28_29() 3853 ret = begin_wide_shared_string(str->len, shift); 3854 } else { 3855 INT32 delimiters = 0; 3856 3857 s = str->str; 3858 >>> CID 742518: (FORWARD_NULL) >>> Dereferencing null pointer "f". 3859 while((s = f(mojt_data, s, (end-s)>>str->size_shift))) 3860 { 3861 delimiters++; 3862 s += del->len << str->size_shift; 3863 } 3864 /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 3877 in f_single_string_replace_cq__backtick_28_29() 3871 (to->len-del->len)*delimiters, shift); 3872 } 3873 3874 s = str->str; 3875 r = MKPCHARP_STR(ret); 3876 >>> CID 742518: (FORWARD_NULL) >>> Dereferencing null pointer "f". 3877 while((tmp = f(mojt_data, s, (end-s)>>str->size_shift))) 3878 { 3879 #ifdef PIKE_DEBUG 3880 if(tmp + (del->len << str->size_shift) > end) 3881 Pike_fatal("SearchMojt found a match beyond end of string!\n"); 3882 #endif ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-stable
by scan-admin＠coverity.com 08 Jul '17

08 Jul '17

Hi, Please find the latest report on new defect(s) introduced to Pike-stable found with Coverity Scan. 1 new defect(s) introduced to Pike-stable found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1414703: Memory - corruptions (ARRAY_VS_SINGLETON) /home/covbuilder/pike/Pike-v8.0-snapshot/src/post_modules/SQLite/sqlite.cmod: 135 in bind_arguments() ________________________________________________________________________________________________________ *** CID 1414703: Memory - corruptions (ARRAY_VS_SINGLETON) /home/covbuilder/pike/Pike-v8.0-snapshot/src/post_modules/SQLite/sqlite.cmod: 135 in bind_arguments() 129 130 case T_MULTISET: 131 if(multiset_sizeof(k->val.u.multiset) == 1) { 132 struct pike_string *s; 133 { 134 struct svalue tmp; >>> CID 1414703: Memory - corruptions (ARRAY_VS_SINGLETON) >>> Using "&k->val.u.multiset->msd->nodes->i" as an array. This might corrupt or misinterpret adjacent memory locations. 135 if (TYPEOF(*use_multiset_index (k->val.u.multiset, 136 multiset_first (k->val.u.multiset), 137 tmp)) == T_STRING) 138 s = tmp.u.string; 139 else 140 s = NULL; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 07 Jul '17

07 Jul '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1414685: Memory - illegal accesses (NEGATIVE_RETURNS) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/SQLite/sqlite.cmod: 131 in bind_arguments() ________________________________________________________________________________________________________ *** CID 1414685: Memory - illegal accesses (NEGATIVE_RETURNS) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/SQLite/sqlite.cmod: 131 in bind_arguments() 125 break; 126 case T_MULTISET: 127 if(multiset_sizeof(k->val.u.multiset) == 1) { 128 struct pike_string *s; 129 { 130 struct svalue tmp; >>> CID 1414685: Memory - illegal accesses (NEGATIVE_RETURNS) >>> Using variable "multiset_first(k->val.u.multiset)" as an index to array "k->val.u.multiset->msd->nodes". 131 if (TYPEOF(*use_multiset_index (k->val.u.multiset, 132 multiset_first (k->val.u.multiset), 133 tmp)) == T_STRING) 134 s = tmp.u.string; 135 else 136 s = NULL; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-stable
by scan-admin＠coverity.com 14 Mar '17

14 Mar '17

Hi, Please find the latest report on new defect(s) introduced to Pike-stable found with Coverity Scan. 7 new defect(s) introduced to Pike-stable found with Coverity Scan. 13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 7 of 7 defect(s) ** CID 1402583: Control flow issues (DEADCODE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/operators.c: 841 in o_cast() ________________________________________________________________________________________________________ *** CID 1402583: Control flow issues (DEADCODE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/operators.c: 841 in o_cast() 835 #ifdef PIKE_DEBUG 836 struct svalue *save_sp=sp+1; 837 #endif 838 839 ptrdiff_t nodepos; 840 if (multiset_indval (tmp)) >>> CID 1402583: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "Pike_error("FIXME: Casting ...". 841 Pike_error ("FIXME: Casting not implemented for multisets with values.\n"); 842 push_multiset (m = allocate_multiset (multiset_sizeof (tmp), 843 multiset_get_flags (tmp), 844 multiset_get_cmp_less (tmp))); 845 846 SET_CYCLIC_RET(m); ** CID 1400859: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 744 in i_img_bmp__decode() /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 757 in i_img_bmp__decode() ________________________________________________________________________________________________________ *** CID 1400859: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 744 in i_img_bmp__decode() 738 push_string(make_shared_binary_string((char *)s,(4<<bpp))); 739 push_int(2); 740 push_object(o=clone_object(image_colortable_program,2)); 741 nct=get_storage(o,image_colortable_program); 742 743 s+=(4<<bpp); >>> CID 1400859: (UNUSED_VALUE) >>> Assigning value from "len - (4 << bpp)" to "len" here, but that stored value is overwritten before it can be used. 744 len-=(4<<bpp); 745 } 746 else 747 { 748 if ((3<<bpp)>len) 749 Pike_error("Image.BMP.decode: unexpected EOF in palette\n"); /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 757 in i_img_bmp__decode() 751 push_string(make_shared_binary_string((char *)s,(3<<bpp))); 752 push_int(1); 753 push_object(o=clone_object(image_colortable_program,2)); 754 nct=get_storage(o,image_colortable_program); 755 756 s+=(3<<bpp); >>> CID 1400859: (UNUSED_VALUE) >>> Assigning value from "len - (3 << bpp)" to "len" here, but that stored value is overwritten before it can be used. 757 len-=(3<<bpp); 758 } 759 760 n++; 761 } 762 ** CID 1400858: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 743 in i_img_bmp__decode() /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 756 in i_img_bmp__decode() ________________________________________________________________________________________________________ *** CID 1400858: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 743 in i_img_bmp__decode() 737 738 push_string(make_shared_binary_string((char *)s,(4<<bpp))); 739 push_int(2); 740 push_object(o=clone_object(image_colortable_program,2)); 741 nct=get_storage(o,image_colortable_program); 742 >>> CID 1400858: (UNUSED_VALUE) >>> Assigning value from "s + (4 << bpp)" to "s" here, but that stored value is overwritten before it can be used. 743 s+=(4<<bpp); 744 len-=(4<<bpp); 745 } 746 else 747 { 748 if ((3<<bpp)>len) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 756 in i_img_bmp__decode() 750 751 push_string(make_shared_binary_string((char *)s,(3<<bpp))); 752 push_int(1); 753 push_object(o=clone_object(image_colortable_program,2)); 754 nct=get_storage(o,image_colortable_program); 755 >>> CID 1400858: (UNUSED_VALUE) >>> Assigning value from "s + (3 << bpp)" to "s" here, but that stored value is overwritten before it can be used. 756 s+=(3<<bpp); 757 len-=(3<<bpp); 758 } 759 760 n++; 761 } ** CID 1400857: (UNINIT) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/image.c: 4113 in image_apply_curve() /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/image.c: 4193 in image_apply_curve() ________________________________________________________________________________________________________ *** CID 1400857: (UNINIT) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/image.c: 4113 in image_apply_curve() 4107 pop_n_elems( args ); 4108 image_apply_curve_3( curve ); 4109 return; 4110 } 4111 case 2: 4112 { >>> CID 1400857: (UNINIT) >>> Declaring variable "curve" without initializer. 4113 unsigned char curve[256]; 4114 int chan = 0, co = 0; 4115 struct object *o; 4116 4117 if( TYPEOF(sp[-args]) != T_STRING ) 4118 SIMPLE_BAD_ARG_ERROR("apply_curve", 1, "string"); /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/image.c: 4193 in image_apply_curve() 4187 pop_stack(); 4188 } 4189 return; 4190 } 4191 case 1: 4192 { >>> CID 1400857: (UNINIT) >>> Declaring variable "curve" without initializer. 4193 unsigned char curve[256]; 4194 if( TYPEOF(sp[-args]) != T_ARRAY || 4195 sp[-args].u.array->size != 256 ) 4196 bad_arg_error("apply_curve", 4197 sp-args, args, 0, "", sp-args, 4198 "Bad arguments to apply_curve.\n" ); ** CID 1400856: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Gz/zlibmod.c: 966 in low_zlibmod_unpack() ________________________________________________________________________________________________________ *** CID 1400856: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Gz/zlibmod.c: 966 in low_zlibmod_unpack() 960 else 961 Pike_error("Failed to initialize Gz.uncompress (%d).\n", ret); 962 } 963 964 mt_init(&z.lock); 965 ret = do_inflate(buf, &z, Z_SYNC_FLUSH); >>> CID 1400856: API usage errors (LOCK) >>> "pthread_mutex_destroy" destroys "z.lock" while it is locked. 966 mt_destroy(&z.lock); 967 inflateEnd( &z.gz ); 968 969 if(ret==Z_OK) 970 Pike_error("Compressed data is truncated.\n"); 971 if(ret!=Z_STREAM_END) ** CID 1400855: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Gz/zlibmod.c: 448 in low_zlibmod_pack() ________________________________________________________________________________________________________ *** CID 1400855: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Gz/zlibmod.c: 448 in low_zlibmod_pack() 442 443 mt_init(&z.lock); 444 445 ret = do_deflate(buf, &z, Z_FINISH); 446 447 deflateEnd(&z.gz); >>> CID 1400855: API usage errors (LOCK) >>> "pthread_mutex_destroy" destroys "z.lock" while it is locked. 448 mt_destroy(&z.lock); 449 450 if(ret != Z_STREAM_END) 451 Pike_error("Error while deflating data (%d).\n",ret); 452 } 453 ** CID 1400854: Insecure data handling (INTEGER_OVERFLOW) /home/covbuilder/pike/Pike-v8.0-snapshot/src/array.c: 95 in real_allocate_array() ________________________________________________________________________________________________________ *** CID 1400854: Insecure data handling (INTEGER_OVERFLOW) /home/covbuilder/pike/Pike-v8.0-snapshot/src/array.c: 95 in real_allocate_array() 89 /* Limits size to (1<<29)-4 */ 90 if( (size_t)(size+extra_space-1) > 91 (LONG_MAX-sizeof(struct array))/sizeof(struct svalue) ) 92 Pike_error("Too large array (size %ld exceeds %ld).\n", 93 (long)(size+extra_space-1), 94 (long)((LONG_MAX-sizeof(struct array))/sizeof(struct svalue)) ); >>> CID 1400854: Insecure data handling (INTEGER_OVERFLOW) >>> Overflowed or truncated value (or a value computed from an overflowed or truncated value) "64UL + (size + extra_space - 1L) * 16UL" used as critical argument to function. 95 v=malloc(sizeof(struct array)+ 96 (size+extra_space-1)*sizeof(struct svalue)); 97 if(!v) 98 Pike_error(msg_out_of_mem_2, sizeof(struct array)+ 99 (size+extra_space-1)*sizeof(struct svalue)); 100 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-experiment
by scan-admin＠coverity.com 26 Feb '17

26 Feb '17

Hi, Please find the latest report on new defect(s) introduced to Pike-experiment found with Coverity Scan. 2 new defect(s) introduced to Pike-experiment found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1401352: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() ________________________________________________________________________________________________________ *** CID 1401352: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() 4456 callsite_set_args(&C, 0); 4457 callsite_resolve_svalue(&C, fun); 4458 callsite_prepare(&C); 4459 /* We need to do this manually, because 4460 * currently no arguments are on the stack, yet */ 4461 C.args = args; >>> CID 1401352: (FORWARD_NULL) >>> Comparing "C.frame" to null implies that "C.frame" might be null. 4462 if (C.frame) { 4463 C.frame->args = args; 4464 C.frame->flags |= PIKE_FRAME_NO_REUSE; 4465 } 4466 4467 for(x=0;x<size;x++) /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() 4456 callsite_set_args(&C, 0); 4457 callsite_resolve_svalue(&C, fun); 4458 callsite_prepare(&C); 4459 /* We need to do this manually, because 4460 * currently no arguments are on the stack, yet */ 4461 C.args = args; >>> CID 1401352: (FORWARD_NULL) >>> Comparing "C.frame" to null implies that "C.frame" might be null. 4462 if (C.frame) { 4463 C.frame->args = args; 4464 C.frame->flags |= PIKE_FRAME_NO_REUSE; 4465 } 4466 4467 for(x=0;x<size;x++) ** CID 1400860: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8543 in f_map() /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8543 in f_map() ________________________________________________________________________________________________________ *** CID 1400860: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8543 in f_map() 8537 callsite_resolve_svalue(&C, mysp-2); 8538 callsite_prepare(&C); 8539 8540 /* We need to do this manually, because 8541 * currently no arguments are on the stack, yet */ 8542 C.args = 1+splice; >>> CID 1400860: (FORWARD_NULL) >>> Comparing "C.frame" to null implies that "C.frame" might be null. 8543 if (C.frame) { 8544 C.frame->args = 1+splice; 8545 C.frame->flags |= PIKE_FRAME_NO_REUSE; 8546 } 8547 8548 for (i=0; i<n; i++) /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8543 in f_map() 8537 callsite_resolve_svalue(&C, mysp-2); 8538 callsite_prepare(&C); 8539 8540 /* We need to do this manually, because 8541 * currently no arguments are on the stack, yet */ 8542 C.args = 1+splice; >>> CID 1400860: (FORWARD_NULL) >>> Comparing "C.frame" to null implies that "C.frame" might be null. 8543 if (C.frame) { 8544 C.frame->args = 1+splice; 8545 C.frame->flags |= PIKE_FRAME_NO_REUSE; 8546 } 8547 8548 for (i=0; i<n; i++) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-experiment
by scan-admin＠coverity.com 20 Feb '17

20 Feb '17

Hi, Please find the latest report on new defect(s) introduced to Pike-experiment found with Coverity Scan. 1 new defect(s) introduced to Pike-experiment found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1401352: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() /home/covbuilder/pike/pike-git/src/builtin.cmod: 4484 in low_automap() ________________________________________________________________________________________________________ *** CID 1401352: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() 4456 callsite_set_args(&C, 0); 4457 callsite_resolve_svalue(&C, fun); 4458 callsite_prepare(&C); 4459 /* We need to do this manually, because 4460 * currently no arguments are on the stack, yet */ 4461 C.args = args; >>> CID 1401352: (FORWARD_NULL) >>> Comparing "C.frame" to null implies that "C.frame" might be null. 4462 if (C.frame) C.frame->args = args; 4463 4464 for(x=0;x<size;x++) 4465 { 4466 for(e=0;e<args;e++) 4467 { /home/covbuilder/pike/pike-git/src/builtin.cmod: 4484 in low_automap() 4478 push_svalue(tmpargs+e); 4479 } 4480 } 4481 4482 if (x) callsite_reset(&C); 4483 callsite_execute(&C); >>> CID 1401352: (FORWARD_NULL) >>> Although "callsite_return" does overwrite "C.frame" on some paths, it also contains at least one feasible path which does not overwrite it. 4484 callsite_return(&C); 4485 stack_pop_to_no_free (ITEM(ret) + x); 4486 types |= 1 << TYPEOF(ITEM(ret)[x]); 4487 } 4488 callsite_free(&C); 4489 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 20 Feb '17

20 Feb '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 8 new defect(s) introduced to Pike-master found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 8 of 8 defect(s) ** CID 1400859: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 748 in i_img_bmp__decode() /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 761 in i_img_bmp__decode() ________________________________________________________________________________________________________ *** CID 1400859: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 748 in i_img_bmp__decode() 742 push_string(make_shared_binary_string((char *)s,(4<<bpp))); 743 push_int(2); 744 push_object(o=clone_object(image_colortable_program,2)); 745 nct=get_storage(o,image_colortable_program); 746 747 s+=(4<<bpp); >>> CID 1400859: (UNUSED_VALUE) >>> Assigning value from "len - (4 << bpp)" to "len" here, but that stored value is overwritten before it can be used. 748 len-=(4<<bpp); 749 } 750 else 751 { 752 if ((3<<bpp)>len) 753 Pike_error("Image.BMP.decode: unexpected EOF in palette\n"); /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 761 in i_img_bmp__decode() 755 push_string(make_shared_binary_string((char *)s,(3<<bpp))); 756 push_int(1); 757 push_object(o=clone_object(image_colortable_program,2)); 758 nct=get_storage(o,image_colortable_program); 759 760 s+=(3<<bpp); >>> CID 1400859: (UNUSED_VALUE) >>> Assigning value from "len - (3 << bpp)" to "len" here, but that stored value is overwritten before it can be used. 761 len-=(3<<bpp); 762 } 763 764 n++; 765 } 766 ** CID 1400858: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 747 in i_img_bmp__decode() /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 760 in i_img_bmp__decode() ________________________________________________________________________________________________________ *** CID 1400858: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 747 in i_img_bmp__decode() 741 742 push_string(make_shared_binary_string((char *)s,(4<<bpp))); 743 push_int(2); 744 push_object(o=clone_object(image_colortable_program,2)); 745 nct=get_storage(o,image_colortable_program); 746 >>> CID 1400858: (UNUSED_VALUE) >>> Assigning value from "s + (4 << bpp)" to "s" here, but that stored value is overwritten before it can be used. 747 s+=(4<<bpp); 748 len-=(4<<bpp); 749 } 750 else 751 { 752 if ((3<<bpp)>len) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 760 in i_img_bmp__decode() 754 755 push_string(make_shared_binary_string((char *)s,(3<<bpp))); 756 push_int(1); 757 push_object(o=clone_object(image_colortable_program,2)); 758 nct=get_storage(o,image_colortable_program); 759 >>> CID 1400858: (UNUSED_VALUE) >>> Assigning value from "s + (3 << bpp)" to "s" here, but that stored value is overwritten before it can be used. 760 s+=(3<<bpp); 761 len-=(3<<bpp); 762 } 763 764 n++; 765 } ** CID 1400857: (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 4152 in image_apply_curve() /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 4232 in image_apply_curve() ________________________________________________________________________________________________________ *** CID 1400857: (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 4152 in image_apply_curve() 4146 pop_n_elems( args ); 4147 image_apply_curve_3( curve ); 4148 return; 4149 } 4150 case 2: 4151 { >>> CID 1400857: (UNINIT) >>> Declaring variable "curve" without initializer. 4152 unsigned char curve[256]; 4153 int chan = 0, co = 0; 4154 struct object *o; 4155 4156 if( TYPEOF(sp[-args]) != T_STRING ) 4157 SIMPLE_ARG_TYPE_ERROR("apply_curve", 1, "string"); /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 4232 in image_apply_curve() 4226 pop_stack(); 4227 } 4228 return; 4229 } 4230 case 1: 4231 { >>> CID 1400857: (UNINIT) >>> Declaring variable "curve" without initializer. 4232 unsigned char curve[256]; 4233 if( TYPEOF(sp[-args]) != T_ARRAY || 4234 sp[-args].u.array->size != 256 ) 4235 bad_arg_error("apply_curve", 4236 sp-args, args, 0, "", sp-args, 4237 "Bad arguments to apply_curve.\n" ); ** CID 1400856: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Gz/zlibmod.c: 948 in low_zlibmod_unpack() ________________________________________________________________________________________________________ *** CID 1400856: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Gz/zlibmod.c: 948 in low_zlibmod_unpack() 942 else 943 Pike_error("Failed to initialize Gz.uncompress (%d).\n", ret); 944 } 945 946 mt_init(&z.lock); 947 ret = do_inflate(buf, &z, Z_SYNC_FLUSH); >>> CID 1400856: API usage errors (LOCK) >>> "pthread_mutex_destroy" destroys "z.lock" while it is locked. 948 mt_destroy(&z.lock); 949 inflateEnd( &z.gz ); 950 951 if(ret==Z_OK) 952 Pike_error("Compressed data is truncated.\n"); 953 if(ret!=Z_STREAM_END) ** CID 1400855: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Gz/zlibmod.c: 447 in low_zlibmod_pack() ________________________________________________________________________________________________________ *** CID 1400855: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Gz/zlibmod.c: 447 in low_zlibmod_pack() 441 442 mt_init(&z.lock); 443 444 ret = do_deflate(buf, &z, Z_FINISH); 445 446 deflateEnd(&z.gz); >>> CID 1400855: API usage errors (LOCK) >>> "pthread_mutex_destroy" destroys "z.lock" while it is locked. 447 mt_destroy(&z.lock); 448 449 if(ret != Z_STREAM_END) 450 Pike_error("Error while deflating data (%d).\n",ret); 451 } 452 ** CID 1400854: Insecure data handling (INTEGER_OVERFLOW) /home/covbuilder/pike/Pike-v8.1-snapshot/src/array.c: 97 in real_allocate_array() ________________________________________________________________________________________________________ *** CID 1400854: Insecure data handling (INTEGER_OVERFLOW) /home/covbuilder/pike/Pike-v8.1-snapshot/src/array.c: 97 in real_allocate_array() 91 /* Limits size to (1<<29)-4 */ 92 if( (size_t)(size+extra_space-1) > 93 (LONG_MAX-sizeof(struct array))/sizeof(struct svalue) ) 94 Pike_error("Too large array (size %ld exceeds %ld).\n", 95 (long)(size+extra_space-1), 96 (long)((LONG_MAX-sizeof(struct array))/sizeof(struct svalue)) ); >>> CID 1400854: Insecure data handling (INTEGER_OVERFLOW) >>> Overflowed or truncated value (or a value computed from an overflowed or truncated value) "56UL + (size + extra_space - 1L) * 16UL" used as critical argument to function. 97 v=malloc(sizeof(struct array)+ 98 (size+extra_space-1)*sizeof(struct svalue)); 99 if(!v) 100 Pike_error(msg_out_of_mem_2, sizeof(struct array)+ 101 (size+extra_space-1)*sizeof(struct svalue)); 102 ** CID 1400853: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 2255 in o_subtract() ________________________________________________________________________________________________________ *** CID 1400853: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 2255 in o_subtract() 2249 return; 2250 2251 case T_INT: 2252 if(INT_TYPE_SUB_OVERFLOW(sp[-2].u.integer, sp[-1].u.integer)) 2253 { 2254 convert_stack_top_to_bignum(); >>> CID 1400853: Error handling issues (CHECKED_RETURN) >>> Calling "call_lfun" without checking return value (as is done elsewhere 18 out of 22 times). 2255 call_lfun(LFUN_SUBTRACT, LFUN_RSUBTRACT); 2256 return; 2257 } 2258 sp--; 2259 SET_SVAL(sp[-1], PIKE_T_INT, NUMBER_NUMBER, integer, 2260 sp[-1].u.integer - sp[0].u.integer); ** CID 1400852: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Nettle/hogweed.cmod: 422 in f_Nettle_ECC_Curve_create() ________________________________________________________________________________________________________ *** CID 1400852: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Nettle/hogweed.cmod: 422 in f_Nettle_ECC_Curve_create() 416 Pike_error("Invalid curve\n"); 417 break; 418 } 419 420 ecc_scalar_init(&THIS->scalar_one, THIS->curve); 421 mpz_init_set_si(mpz_one, 1); >>> CID 1400852: Error handling issues (CHECKED_RETURN) >>> Calling "nettle_ecc_scalar_set" without checking return value (as is done elsewhere 4 out of 5 times). 422 ecc_scalar_set(&THIS->scalar_one, mpz_one); 423 mpz_clear(mpz_one); 424 } 425 426 /*! @decl protected local int(0..1) `==(mixed x) 427 *! ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

Pike-automation