Hi,
Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan.
5 new defect(s) introduced to Pike-master found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s)
** CID 1358398: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_8bit_cube()
________________________________________________________________________________________________________ *** CID 1358398: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_8bit_cube() 429 { 430 lc->dest.r=((int)(((val.r*red+hred)>>8)*redf)); 431 lc->dest.g=((int)(((val.g*green+hgreen)>>8)*greenf)); 432 lc->dest.b=((int)(((val.b*blue+hblue)>>8)*bluef)); 433 434 lc->index=i=
CID 1358398: Code maintainability issues (UNUSED_VALUE) Assigning value from "(val.r * red + hred >> 8) + ((val.g * green + hgreen >> 8) + (val.b * blue + hblue >> 8) * green) * red" to "i" here, but that stored value is overwritten before it can be used.
435 ((val.r*red+hred)>>8)+ 436 (((val.g*green+hgreen)>>8)+ 437 ((val.b*blue+hblue)>>8)*green)*red; 438 439 NCTLU_CACHE_HIT_WRITE; 440
** CID 1358397: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_32bit_cube()
________________________________________________________________________________________________________ *** CID 1358397: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_32bit_cube() 429 { 430 lc->dest.r=((int)(((val.r*red+hred)>>8)*redf)); 431 lc->dest.g=((int)(((val.g*green+hgreen)>>8)*greenf)); 432 lc->dest.b=((int)(((val.b*blue+hblue)>>8)*bluef)); 433 434 lc->index=i=
CID 1358397: Code maintainability issues (UNUSED_VALUE) Assigning value from "(val.r * red + hred >> 8) + ((val.g * green + hgreen >> 8) + (val.b * blue + hblue >> 8) * green) * red" to "i" here, but that stored value is overwritten before it can be used.
435 ((val.r*red+hred)>>8)+ 436 (((val.g*green+hgreen)>>8)+ 437 ((val.b*blue+hblue)>>8)*green)*red; 438 439 NCTLU_CACHE_HIT_WRITE; 440
** CID 1358396: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_16bit_cube()
________________________________________________________________________________________________________ *** CID 1358396: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_index_16bit_cube() 429 { 430 lc->dest.r=((int)(((val.r*red+hred)>>8)*redf)); 431 lc->dest.g=((int)(((val.g*green+hgreen)>>8)*greenf)); 432 lc->dest.b=((int)(((val.b*blue+hblue)>>8)*bluef)); 433 434 lc->index=i=
CID 1358396: Code maintainability issues (UNUSED_VALUE) Assigning value from "(val.r * red + hred >> 8) + ((val.g * green + hgreen >> 8) + (val.b * blue + hblue >> 8) * green) * red" to "i" here, but that stored value is overwritten before it can be used.
435 ((val.r*red+hred)>>8)+ 436 (((val.g*green+hgreen)>>8)+ 437 ((val.b*blue+hblue)>>8)*green)*red; 438 439 NCTLU_CACHE_HIT_WRITE; 440
** CID 1358395: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_map_to_cube()
________________________________________________________________________________________________________ *** CID 1358395: Code maintainability issues (UNUSED_VALUE) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/Image/colortable_lookup.h: 435 in _img_nct_map_to_cube() 429 { 430 lc->dest.r=((int)(((val.r*red+hred)>>8)*redf)); 431 lc->dest.g=((int)(((val.g*green+hgreen)>>8)*greenf)); 432 lc->dest.b=((int)(((val.b*blue+hblue)>>8)*bluef)); 433 434 lc->index=i=
CID 1358395: Code maintainability issues (UNUSED_VALUE) Assigning value from "(val.r * red + hred >> 8) + ((val.g * green + hgreen >> 8) + (val.b * blue + hblue >> 8) * green) * red" to "i" here, but that stored value is overwritten before it can be used.
435 ((val.r*red+hred)>>8)+ 436 (((val.g*green+hgreen)>>8)+ 437 ((val.b*blue+hblue)>>8)*green)*red; 438 439 NCTLU_CACHE_HIT_WRITE; 440
** CID 1358394: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/system/system.c: 1894 in get_inet_addr()
________________________________________________________________________________________________________ *** CID 1358394: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /home/covscan/pike/Pike-v8.1-snapshot/src/modules/system/system.c: 1894 in get_inet_addr() 1888 * cf [bug 7599] and https://bugs.python.org/issue17269 . 1889 */ 1890 hints.ai_flags |= AI_NUMERICSERV; 1891 sprintf(service = servnum_buf, "%"PRINTPIKEINT"d", port & 0xffff); 1892 } 1893
CID 1358394: Integer handling issues (CONSTANT_EXPRESSION_RESULT) The expression "(err = getaddrinfo(name, service, &hints, &res)) && 4" is suspicious because it performs a Boolean operation on a constant other than 0 or 1.
1894 if( (err=getaddrinfo(name, service, &hints, &res)) && AI_NUMERICHOST ) 1895 { 1896 /* Try again without AI_NUMERICHOST. */ 1897 hints.ai_flags &= ~AI_NUMERICHOST; 1898 err=getaddrinfo(name, service, &hints, &res); 1899 }
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/pike-master?tab=overview
To manage Coverity Scan email notifications for "pike-automation@lists.lysator.liu.se", click https://scan.coverity.com/subscriptions/edit?email=pike-automation%40lists.l...