Hi,
Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan.
3 new defect(s) introduced to Pike-master found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s)
** CID 1458076: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3724 in yysyntax_error()
________________________________________________________________________________________________________ *** CID 1458076: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3724 in yysyntax_error() 3718 } 3719 3720 if (*yymsg_alloc < yysize) 3721 { 3722 *yymsg_alloc = 2 * yysize; 3723 if (! (yysize <= *yymsg_alloc
CID 1458076: Integer handling issues (CONSTANT_EXPRESSION_RESULT) "*yymsg_alloc <= 9223372036854775807L /* (long)((9223372036854775807L < (unsigned long)-1) ? 9223372036854775807L : (unsigned long)-1) */" is always true regardless of the values of its operands. This occurs as the logical second operand of "&&".
3724 && *yymsg_alloc <= YYSTACK_ALLOC_MAXIMUM)) 3725 *yymsg_alloc = YYSTACK_ALLOC_MAXIMUM; 3726 return 1; 3727 } 3728 3729 /* Avoid sprintf, as that infringes on the user's name space.
** CID 1458072: (CONSTANT_EXPRESSION_RESULT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3714 in yysyntax_error() /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3685 in yysyntax_error()
________________________________________________________________________________________________________ *** CID 1458072: (CONSTANT_EXPRESSION_RESULT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3714 in yysyntax_error() 3708 } 3709 3710 { 3711 /* Don't count the "%s"s in the final size, but reserve room for 3712 the terminator. */ 3713 YYPTRDIFF_T yysize1 = yysize + (yystrlen (yyformat) - 2 * yycount) + 1;
CID 1458072: (CONSTANT_EXPRESSION_RESULT) "yysize1 <= 9223372036854775807L /* (long)((9223372036854775807L < (unsigned long)-1) ? 9223372036854775807L : (unsigned long)-1) */" is always true regardless of the values of its operands. This occurs as the logical second operand of "&&".
3714 if (yysize <= yysize1 && yysize1 <= YYSTACK_ALLOC_MAXIMUM) 3715 yysize = yysize1; 3716 else 3717 return 2; 3718 } 3719 /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3685 in yysyntax_error() 3679 break; 3680 } 3681 yyarg[yycount++] = yytname[yyx]; 3682 { 3683 YYPTRDIFF_T yysize1 3684 = yysize + yytnamerr (YY_NULLPTR, yytname[yyx]);
CID 1458072: (CONSTANT_EXPRESSION_RESULT) "yysize1 <= 9223372036854775807L /* (long)((9223372036854775807L < (unsigned long)-1) ? 9223372036854775807L : (unsigned long)-1) */" is always true regardless of the values of its operands. This occurs as the logical second operand of "&&".
3685 if (yysize <= yysize1 && yysize1 <= YYSTACK_ALLOC_MAXIMUM) 3686 yysize = yysize1; 3687 else 3688 return 2; 3689 } 3690 }
** CID 20290: Control flow issues (MISSING_BREAK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3580 in yytnamerr()
________________________________________________________________________________________________________ *** CID 20290: Control flow issues (MISSING_BREAK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3580 in yytnamerr() 3574 switch (*++yyp) 3575 { 3576 case ''': 3577 case ',': 3578 goto do_not_strip_quotes; 3579
CID 20290: Control flow issues (MISSING_BREAK) The case for value "'\\'" is not terminated by a 'break' statement.
3580 case '\': 3581 if (*++yyp != '\') 3582 goto do_not_strip_quotes; 3583 else 3584 goto append; 3585
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...