Re: Annotate non-zero-terminated character arrays

Georg Sauthoff nettle@gms.tf writes:

...

1. Simply add the trailing NUL byte, e.g., instead of

...

static const uint8_t -hex_digits[16] = "0123456789abcdef"; +hex_digits[16] NONSTRING = "0123456789abcdef";

change it to

hex_digits[17] = "0123456789abcdef";

or just

hex_digits = "0123456789abcdef";

(will need code adjustments if sizeof is applied to affected string constants).

I can see how the sizeof change could confuse and trick people, i.e. sounds like a foot-gun one would want to avoid.

Indeed -- and I think using sizeof on C string arrays declared with hard-coded magical values can be hard to read. One way around that would be:

#define HEX_ALPHABET_LEN 16 const uint8_t hex_digits[HEX_ALPHABET_LEN] = { '0', ... 'f' };

and to replace all uses of 'sizeof hex_digits' with HEX_ALPHABET_LEN.

/Simon